Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/cbor: Add support for generic versioned blobs #3052

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 25, 2020

No description provided.

@Yawning Yawning force-pushed the yawning/trivial/versioned-cbor branch from 70167d6 to 842d144 Compare June 25, 2020 11:46
@@ -0,0 +1,4 @@
go/common/cbor: Add support for generic versioned blobs

Having to push, get a PR number, and then write these things is stupid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can predict what number you'll get or you can open an issue so you have a known identifier.

@Yawning Yawning force-pushed the yawning/trivial/versioned-cbor branch from 842d144 to ba0cfb2 Compare June 25, 2020 12:23
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #3052 into master will increase coverage by 0.07%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
+ Coverage   68.26%   68.34%   +0.07%     
==========================================
  Files         371      372       +1     
  Lines       36424    36437      +13     
==========================================
+ Hits        24866    24903      +37     
+ Misses       8347     8338       -9     
+ Partials     3211     3196      -15     
Impacted Files Coverage Δ
go/common/cbor/versioned.go 69.23% <69.23%> (ø)
...nsensus/tendermint/apps/keymanager/transactions.go 44.11% <0.00%> (-8.83%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 74.46% <0.00%> (-8.52%) ⬇️
...ensus/tendermint/apps/staking/proposing_rewards.go 82.85% <0.00%> (-5.72%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/roothash/roothash.go 63.87% <0.00%> (-2.61%) ⬇️
go/keymanager/client/client.go 82.64% <0.00%> (-1.66%) ⬇️
go/worker/compute/executor/committee/node.go 61.16% <0.00%> (-1.32%) ⬇️
go/registry/api/api.go 41.65% <0.00%> (-0.91%) ⬇️
go/staking/api/grpc.go 53.19% <0.00%> (-0.88%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ecca2...ba0cfb2. Read the comment docs.

@Yawning Yawning merged commit 5373604 into master Jun 25, 2020
@Yawning Yawning deleted the yawning/trivial/versioned-cbor branch June 25, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants