Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker: Defer various processing #3049

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 25, 2020

  • go/worker/compute/executor: Defer fetching the batch from storage

    There is no need to attempt to fetch the batch immediately, we can defer it to
    when we actually need to start processing the batch. This makes fetching not
    block P2P dispatch.

  • go/worker/compute/merge: Defer finalization attempt

    There is no need for the finalization attempt to block handling of an incoming
    commitment as any errors from that are not propagated. This avoids blocking
    P2P relaying as well.

  • go/worker/common: Treat unknown P2P message type as a permanent error

kostko added 3 commits June 25, 2020 11:14
There is no need to attempt to fetch the batch immediately, we can defer it to
when we actually need to start processing the batch. This makes fetching not
block P2P dispatch.
There is no need for the finalization attempt to block handling of an incoming
commitment as any errors from that are not propagated. This avoids blocking
P2P relaying as well.
@kostko kostko force-pushed the kostko/fix/compute-p2p-dispatch branch from be3b60a to ac52c75 Compare June 25, 2020 09:15
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #3049 into master will decrease coverage by 0.08%.
The diff coverage is 81.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   68.46%   68.37%   -0.09%     
==========================================
  Files         370      371       +1     
  Lines       36401    36424      +23     
==========================================
- Hits        24921    24904      -17     
- Misses       8283     8312      +29     
- Partials     3197     3208      +11     
Impacted Files Coverage Δ
go/worker/common/committee/node.go 72.88% <0.00%> (ø)
go/worker/compute/executor/committee/state.go 88.88% <ø> (+3.70%) ⬆️
go/worker/compute/executor/committee/batch.go 69.23% <69.23%> (ø)
go/worker/compute/merge/committee/node.go 76.38% <77.77%> (-1.51%) ⬇️
go/worker/compute/executor/committee/node.go 64.35% <86.44%> (-2.13%) ⬇️
go/runtime/transaction/batch.go 0.00% <0.00%> (-100.00%) ⬇️
go/storage/mkvs/lookup.go 73.46% <0.00%> (-4.09%) ⬇️
go/storage/metrics.go 75.00% <0.00%> (-3.27%) ⬇️
go/worker/storage/service_external.go 43.01% <0.00%> (-2.16%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3590df4...ac52c75. Read the comment docs.

@kostko kostko merged commit 695b240 into master Jun 25, 2020
@kostko kostko deleted the kostko/fix/compute-p2p-dispatch branch June 25, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants