Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing EarlyLogAndExit() in CLI commands #3048

Closed
tjanez opened this issue Jun 25, 2020 · 1 comment · Fixed by #3230
Closed

Consider replacing EarlyLogAndExit() in CLI commands #3048

tjanez opened this issue Jun 25, 2020 · 1 comment · Fixed by #3230
Labels
c:cli Category: command line interface

Comments

@tjanez
Copy link
Member

tjanez commented Jun 25, 2020

SUMMARY

Following up from #3044 (comment), we should should check the uses of github.com/oasisprotocol/oasis-core/go/oasis-node/cmd/common.EarlyLogAndExit() and replace it with os.Exit() where appropriate to avoid printing error message twice (for an example, see f5f906b).

ISSUE TYPE
  • Clean-up
@tjanez tjanez added the c:cli Category: command line interface label Jun 25, 2020
@tjanez tjanez mentioned this issue Jun 25, 2020
Merged
@tjanez tjanez changed the title Consider replace EarlyLogAndExit() in CLI commands Consider replacing EarlyLogAndExit() in CLI commands Jun 25, 2020
@tjanez tjanez mentioned this issue Sep 3, 2020
Merged
@tjanez
Copy link
Member Author

tjanez commented Sep 3, 2020

we should should check the uses of github.com/oasisprotocol/oasis-core/go/oasis-node/cmd/common.EarlyLogAndExit() and replace it with os.Exit() where appropriate to avoid printing error message twice.

I did that in #3230, other uses cases are appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:cli Category: command line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go: Fix CLI tools to not print error messages twice oasisprotocol/oasis-core
1 participant
@tjanez