Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't automatically retry timed out jobs #3036

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 19, 2020

Apparently jobs that timeout exit with status 255 and those shouldn't be automatically retried.

As noted before (#2900) 125 is actually the only error we want to automatically retry.

@ptrus ptrus force-pushed the ptrus/ci/dont-retry-timeouts branch from d268ada to 5dad5de Compare June 19, 2020 14:27
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #3036 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   68.47%   68.54%   +0.07%     
==========================================
  Files         367      367              
  Lines       36238    36238              
==========================================
+ Hits        24813    24840      +27     
+ Misses       8225     8210      -15     
+ Partials     3200     3188      -12     
Impacted Files Coverage Δ
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/common/grpc/proxy/proxy.go 62.60% <0.00%> (-5.22%) ⬇️
go/worker/common/p2p/p2p.go 64.41% <0.00%> (-4.51%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 77.58% <0.00%> (-3.45%) ⬇️
go/consensus/tendermint/roothash/roothash.go 66.47% <0.00%> (-2.03%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.26% <0.00%> (-1.21%) ⬇️
go/runtime/client/client.go 72.26% <0.00%> (-0.73%) ⬇️
go/storage/api/grpc.go 66.88% <0.00%> (-0.67%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba384fc...5dad5de. Read the comment docs.

@ptrus ptrus merged commit adbf222 into master Jun 19, 2020
@ptrus ptrus deleted the ptrus/ci/dont-retry-timeouts branch June 19, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants