Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/encoding/bech32: Replace to-be-removed dependency #3030

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 18, 2020

The github.com/tendermint/tendermint/libs/bech32 module has been removed in
later Tendermint Core versions. As it only contained a small helper, we just
copy it over.

@kostko kostko requested a review from tjanez June 18, 2020 11:36
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #3030 into master will increase coverage by 0.07%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
+ Coverage   68.44%   68.51%   +0.07%     
==========================================
  Files         367      367              
  Lines       36126    36135       +9     
==========================================
+ Hits        24725    24758      +33     
+ Misses       8244     8186      -58     
- Partials     3157     3191      +34     
Impacted Files Coverage Δ
go/common/encoding/bech32/bech32.go 69.23% <63.63%> (-30.77%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/worker/compute/executor/committee/fault.go 68.96% <0.00%> (-8.05%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/storage/metrics.go 78.26% <0.00%> (-6.53%) ⬇️
go/storage/mkvs/lookup.go 73.46% <0.00%> (-4.09%) ⬇️
go/consensus/tendermint/abci/state.go 67.62% <0.00%> (-3.60%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-2.30%) ⬇️
go/storage/mkvs/cache.go 81.27% <0.00%> (-1.71%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca7a1d...3c435d5. Read the comment docs.

The github.com/tendermint/tendermint/libs/bech32 module has been removed in
later Tendermint Core versions. As it only contained a small helper, we just
copy it over.
@kostko kostko force-pushed the kostko/fix/bech32-notm branch from 974aa04 to 3c435d5 Compare June 18, 2020 13:29
@kostko kostko merged commit 02a9458 into master Jun 18, 2020
@kostko kostko deleted the kostko/fix/bech32-notm branch June 18, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants