Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staking: Don't emit zero-amount staking events #2983

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

abukosek
Copy link
Contributor

@abukosek abukosek commented Jun 8, 2020

If fees were set to 0, staking events related to the fee accumulator
would still get emitted with zero amounts, which is pointless.

This fix affects only events related to the internal fee accumulator
and common pool accounts, manual transfers with 0 as the amount will
still get emitted.

If fees were set to 0, staking events related to the fee accumulator
would still get emitted with zero amounts, which is pointless.

This fix affects only events related to the internal fee accumulator
and common pool accounts, manual transfers with 0 as the amount will
still get emitted.
@abukosek abukosek force-pushed the andrej/bugfix/0-amount-staking-events branch from 9f625d2 to df80544 Compare June 8, 2020 09:50
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #2983 into master will increase coverage by 0.25%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2983      +/-   ##
==========================================
+ Coverage   68.51%   68.77%   +0.25%     
==========================================
  Files         360      360              
  Lines       35386    35379       -7     
==========================================
+ Hits        24246    24333      +87     
+ Misses       8035     7936      -99     
- Partials     3105     3110       +5     
Impacted Files Coverage Δ
go/staking/tests/tester.go 92.12% <40.00%> (-1.87%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 47.44% <100.00%> (ø)
go/consensus/tendermint/apps/staking/state/gas.go 80.00% <100.00%> (-3.34%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 55.43% <0.00%> (-2.18%) ⬇️
...consensus/tendermint/apps/scheduler/state/state.go 71.15% <0.00%> (-1.93%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1266304...df80544. Read the comment docs.

@abukosek abukosek marked this pull request as ready for review June 8, 2020 10:12
@abukosek abukosek merged commit 7d855c6 into master Jun 8, 2020
@abukosek abukosek deleted the andrej/bugfix/0-amount-staking-events branch June 8, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants