Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/storage/mkvs: Add method for checking local key existence #2938

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

jberci
Copy link
Contributor

@jberci jberci commented May 22, 2020

No description provided.

@jberci jberci force-pushed the jberci/feature/mkvs-contains branch from 6cc13d9 to 137259d Compare May 22, 2020 16:34
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #2938 into master will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
- Coverage   68.41%   68.36%   -0.05%     
==========================================
  Files         361      361              
  Lines       35220    35231      +11     
==========================================
- Hits        24095    24085      -10     
- Misses       8021     8035      +14     
- Partials     3104     3111       +7     
Impacted Files Coverage Δ
go/oasis-node/cmd/genesis/genesis.go 52.40% <27.27%> (-0.65%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/worker/common/p2p/p2p.go 61.71% <0.00%> (-4.51%) ⬇️
go/consensus/tendermint/apps/registry/registry.go 62.16% <0.00%> (-4.51%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/runtime/transaction/transaction.go 74.54% <0.00%> (-3.64%) ⬇️
go/storage/client/client.go 75.33% <0.00%> (-2.65%) ⬇️
go/storage/mkvs/iterator.go 83.12% <0.00%> (-2.50%) ⬇️
go/consensus/tendermint/roothash/roothash.go 66.21% <0.00%> (-2.37%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6de84...fb20be9. Read the comment docs.

@jberci jberci force-pushed the jberci/feature/mkvs-contains branch from 137259d to d936b56 Compare May 28, 2020 13:04
@jberci jberci marked this pull request as ready for review May 28, 2020 14:24
@jberci jberci force-pushed the jberci/feature/mkvs-contains branch 3 times, most recently from 142dbc0 to 10b4c0b Compare June 1, 2020 13:24
@jberci jberci force-pushed the jberci/feature/mkvs-contains branch from 10b4c0b to fb20be9 Compare June 1, 2020 14:34
@jberci jberci merged commit 25c748f into master Jun 1, 2020
@jberci jberci deleted the jberci/feature/mkvs-contains branch June 1, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants