Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/crypto/hash: Add NewFrom and NewFromBytes functions #2890

Merged
merged 1 commit into from
May 6, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented May 6, 2020

No description provided.

@kostko kostko force-pushed the kostko/feature/hash-newfrom branch from b83f581 to f007423 Compare May 6, 2020 10:46
@kostko kostko mentioned this pull request May 6, 2020
2 tasks
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #2890 into master will increase coverage by 0.03%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2890      +/-   ##
==========================================
+ Coverage   67.74%   67.78%   +0.03%     
==========================================
  Files         352      352              
  Lines       34215    34188      -27     
==========================================
- Hits        23179    23173       -6     
+ Misses       8071     8056      -15     
+ Partials     2965     2959       -6     
Impacted Files Coverage Δ
go/storage/mkvs/checkpoint/checkpoint.go 86.66% <0.00%> (+10.19%) ⬆️
go/worker/common/committee/group.go 80.59% <0.00%> (+0.91%) ⬆️
go/consensus/tendermint/abci/mux.go 69.97% <50.00%> (-0.60%) ⬇️
go/common/accessctl/accessctl.go 100.00% <100.00%> (ø)
go/common/crypto/hash/hash.go 84.61% <100.00%> (+2.00%) ⬆️
go/common/namespace.go 83.67% <100.00%> (-0.33%) ⬇️
go/common/node/node.go 70.00% <100.00%> (-0.54%) ⬇️
go/consensus/api/transaction/transaction.go 61.97% <100.00%> (-1.05%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 60.80% <100.00%> (+0.32%) ⬆️
go/consensus/tendermint/tendermint.go 66.24% <100.00%> (-0.05%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a8fa4...f007423. Read the comment docs.

Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh, much nicer.

@kostko kostko merged commit b916601 into master May 6, 2020
@kostko kostko deleted the kostko/feature/hash-newfrom branch May 6, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants