Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/rpc: Change session identifier on reset, add unit tests #2872

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 28, 2020

Previously the EnclaveRPC client did not change the session identifier on reset, resulting in unnecessary round-trips during a transport error. The EnclaveRPC client now changes the session identifier and the code now includes unit tests for the EnclaveRPC client (and demux).

@kostko kostko added c:testing Category: testing c:runtime Category: runtime labels Apr 28, 2020
@kostko kostko self-assigned this Apr 28, 2020
@kostko kostko force-pushed the kostko/fix/enclaverpc-client-session branch from 22651c8 to fb00135 Compare April 28, 2020 08:43
@kostko kostko marked this pull request as ready for review April 28, 2020 08:57
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #2872 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2872   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files         344      344           
  Lines       33530    33530           
=======================================
+ Hits        22700    22703    +3     
- Misses       7915     7917    +2     
+ Partials     2915     2910    -5     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
go/runtime/committee/nodes.go 80.39% <0.00%> (-3.93%) ⬇️
go/storage/metrics.go 84.78% <0.00%> (-3.27%) ⬇️
go/consensus/tendermint/api/state.go 51.85% <0.00%> (-2.47%) ⬇️
go/consensus/tendermint/scheduler/scheduler.go 76.41% <0.00%> (-1.89%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 64.50% <0.00%> (-1.86%) ⬇️
go/storage/database/database.go 79.09% <0.00%> (-1.82%) ⬇️
go/worker/keymanager/worker.go 58.50% <0.00%> (-1.50%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 67.63% <0.00%> (-1.32%) ⬇️
go/staking/api/grpc.go 52.61% <0.00%> (-0.99%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7736d...fb00135. Read the comment docs.

@kostko kostko merged commit e03912f into master Apr 28, 2020
@kostko kostko deleted the kostko/fix/enclaverpc-client-session branch April 28, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime Category: runtime c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants