Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Genesis document's hash when creating transactions with the CLI #2871

Closed
tjanez opened this issue Apr 27, 2020 · 3 comments · Fixed by #3157
Closed

Display Genesis document's hash when creating transactions with the CLI #2871

tjanez opened this issue Apr 27, 2020 · 3 comments · Fixed by #3157
Assignees
Labels
c:cli Category: command line interface c:staking Category: staking

Comments

@tjanez
Copy link
Member

tjanez commented Apr 27, 2020

SUMMARY

When a user creates a transaction with the CLI, e.g.:

oasis-node stake account gen_transfer \
  --genesis.file /localhostdir/genesis.json \
  --signer ledger \
  --signer.ledger.address oasis19hpt4y2reqwyfqcd53asjchdqf468chr673y6jn07xjp36w32jlscf0me \
  --signer.ledger.index 1 \
  --signer.dir /localhostdir/entity/
  --stake.amount 170000000000 \
  --stake.transfer.destination A1X90rT/WK4AOTh/dJsUlOqNDV/nXM6ZU+h+blS9pto= \
  --transaction.file tx_transfer.json \
  --transaction.nonce 1 \
  --transaction.fee.gas 1000 \
  --transaction.fee.amount 2000

and uses a Ledger device to sign it, he needs to verify the Genesis document's hash on the Ledger device's screen.

To make that verification easier, print the Genesis document's hash to the log when creating a transaction with one of the oasis-node stake account get_* commands.

ISSUE TYPE
  • Feature Idea
@tjanez tjanez added c:staking Category: staking c:cli Category: command line interface labels Apr 27, 2020
@kostko
Copy link
Member

kostko commented Apr 27, 2020

Also show_tx should probably display the genesis document hash as well.

@kostko
Copy link
Member

kostko commented Jun 22, 2020

It would also be cool to have a genesis subcommand for deriving and displaying the genesis document hash (maybe this could be part of oasis-node genesis check).

@tjanez
Copy link
Member Author

tjanez commented Aug 3, 2020

It would also be cool to have a genesis subcommand for deriving and displaying the genesis document hash (maybe this could be part of oasis-node genesis check).

This part has been extracted to #3163.

@tjanez tjanez closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:staking Category: staking
Projects
None yet
2 participants