Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/extra/stats: fix heights at which missing nodes should be queried #2858

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 21, 2020

If we encounter a signature for a node that is not yet being tracked, we should query for it's info on the previous height, as that's the block at which the vote was made.

Tested on blocks 0-69488 questnet.

If a missing signature is encountered, the registry should be queried at
previous height, since that is the height at which the vote was made.
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #2858 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
- Coverage   67.82%   67.70%   -0.12%     
==========================================
  Files         344      344              
  Lines       33426    33426              
==========================================
- Hits        22670    22631      -39     
- Misses       7869     7897      +28     
- Partials     2887     2898      +11     
Impacted Files Coverage Δ
go/storage/metrics.go 88.04% <0.00%> (-3.27%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <0.00%> (-2.37%) ⬇️
go/storage/api/root_cache.go 77.01% <0.00%> (-2.30%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 55.43% <0.00%> (-2.18%) ⬇️
go/consensus/tendermint/abci/mux.go 69.14% <0.00%> (-2.03%) ⬇️
...consensus/tendermint/apps/scheduler/state/state.go 71.15% <0.00%> (-1.93%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 64.50% <0.00%> (-1.86%) ⬇️
go/storage/database/database.go 79.09% <0.00%> (-1.82%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 38.39% <0.00%> (-1.79%) ⬇️
go/roothash/api/commitment/pool.go 69.94% <0.00%> (-1.69%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8104502...2136c66. Read the comment docs.

@ptrus ptrus merged commit 4ef7c99 into master Apr 21, 2020
@ptrus ptrus deleted the ptrus/fix/stats-height branch April 21, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants