Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/crypto/mrae/deoxysii: Use SHA512/256 for the KDF #2853

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Apr 17, 2020

Following 73aacaa, this should also use
the correct hash algorithm for the KDF.

@Yawning Yawning self-assigned this Apr 17, 2020
@Yawning Yawning force-pushed the yawning/fix/mrae-hash branch from 0f6e140 to c6a5d36 Compare April 17, 2020 15:30
Following 73aacaa, this should also use
the correct hash algorithm for the KDF.
@Yawning Yawning force-pushed the yawning/fix/mrae-hash branch from c6a5d36 to f12232a Compare April 17, 2020 15:42
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #2853 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2853      +/-   ##
==========================================
- Coverage   67.38%   67.33%   -0.05%     
==========================================
  Files         344      344              
  Lines       33406    33406              
==========================================
- Hits        22509    22495      -14     
- Misses       7998     8007       +9     
- Partials     2899     2904       +5     
Impacted Files Coverage Δ
go/common/crypto/mrae/deoxysii/asymmetric.go 81.81% <100.00%> (ø)
go/consensus/tendermint/apps/roothash/query.go 64.70% <0.00%> (-11.77%) ⬇️
go/consensus/tendermint/abci/state/state.go 50.00% <0.00%> (-7.70%) ⬇️
go/common/cbor/codec.go 77.14% <0.00%> (-5.72%) ⬇️
go/worker/common/p2p/p2p.go 61.71% <0.00%> (-4.51%) ⬇️
go/runtime/committee/nodes.go 80.39% <0.00%> (-3.93%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 68.62% <0.00%> (-3.93%) ⬇️
go/staking/api/grpc.go 52.61% <0.00%> (-0.99%) ⬇️
go/storage/client/client.go 77.09% <0.00%> (-0.89%) ⬇️
go/consensus/tendermint/abci/state.go 69.11% <0.00%> (-0.78%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0430d...f12232a. Read the comment docs.

@Yawning Yawning merged commit 33e86c0 into master Apr 17, 2020
@Yawning Yawning deleted the yawning/fix/mrae-hash branch April 17, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants