Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-test-runner/txsource: Generate a new random seed on each run #2849

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 16, 2020

I remembered we don't actually change the seed 😁

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #2849 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
+ Coverage   67.36%   67.41%   +0.04%     
==========================================
  Files         344      344              
  Lines       33411    33411              
==========================================
+ Hits        22508    22523      +15     
+ Misses       7996     7992       -4     
+ Partials     2907     2896      -11     
Impacted Files Coverage Δ
go/consensus/tendermint/roothash/roothash.go 62.50% <0.00%> (-5.41%) ⬇️
go/consensus/tendermint/abci/timer.go 67.01% <0.00%> (-5.16%) ⬇️
go/storage/mkvs/remove.go 85.85% <0.00%> (-4.05%) ⬇️
go/storage/client/client.go 75.33% <0.00%> (-1.77%) ⬇️
go/storage/mkvs/cache.go 81.27% <0.00%> (-1.71%) ⬇️
go/storage/mkvs/iterator.go 83.12% <0.00%> (-1.25%) ⬇️
go/common/grpc/grpc.go 79.42% <0.00%> (-1.24%) ⬇️
go/runtime/transaction/transaction.go 74.69% <0.00%> (-1.21%) ⬇️
go/consensus/tendermint/tendermint.go 67.24% <0.00%> (-0.54%) ⬇️
go/worker/registration/worker.go 66.73% <0.00%> (-0.42%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2092f90...c12b682. Read the comment docs.

@kostko kostko marked this pull request as ready for review April 16, 2020 16:33
@kostko kostko force-pushed the kostko/feature/txsource-random-seed branch from 301889d to c12b682 Compare April 20, 2020 09:05
@kostko kostko merged commit df4173e into master Apr 20, 2020
@kostko kostko deleted the kostko/feature/txsource-random-seed branch April 20, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants