-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oasis-net-runner: Add support for loading fixtures from JSON #2848
Conversation
4e00ccb
to
902f729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an example fixture under tests/fixture-data/net-runner/default.json
.
Also add some unit tests for dumping/loading a fixture and making sure it looks correct.
902f729
to
55ff06d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2848 +/- ##
==========================================
+ Coverage 67.64% 67.74% +0.09%
==========================================
Files 344 344
Lines 33530 33530
==========================================
+ Hits 22682 22714 +32
+ Misses 7922 7900 -22
+ Partials 2926 2916 -10
Continue to review full report at Codecov.
|
d25e189
to
00f7d6f
Compare
c01cd1c
to
c80853b
Compare
c80853b
to
21e08c2
Compare
Don't forget to squash :-) |
21e08c2
to
b2b5339
Compare
Merged, thanks. |
This PR resolves #2779
Changelog: https://raw.githubusercontent.com/oasislabs/oasis-core/matevz/feature/json_fixtures/.changelog/2848.feature.md