Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go consensus: shorten gas import #2802

Merged
merged 3 commits into from
Apr 1, 2020
Merged

go consensus: shorten gas import #2802

merged 3 commits into from
Apr 1, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Apr 1, 2020

switch to more concise FromUint64

@pro-wh pro-wh requested a review from kostko April 1, 2020 18:16
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2802 into master will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
- Coverage   61.89%   61.58%   -0.31%     
==========================================
  Files         386      386              
  Lines       37234    37234              
==========================================
- Hits        23046    22932     -114     
- Misses      11135    11262     +127     
+ Partials     3053     3040      -13     
Impacted Files Coverage Δ
go/consensus/api/transaction/gas.go 60.00% <0.00%> (ø)
.../oasis-node/cmd/debug/txsource/workload/runtime.go 1.77% <0.00%> (-55.63%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/consensus/api/grpc.go 59.30% <0.00%> (-4.66%) ⬇️
go/storage/metrics.go 81.52% <0.00%> (-3.27%) ⬇️
go/storage/mkvs/iterator.go 83.12% <0.00%> (-2.50%) ⬇️
go/runtime/transaction/transaction.go 74.69% <0.00%> (-2.41%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-2.18%) ⬇️
go/storage/client/client.go 75.93% <0.00%> (-2.08%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.34% <0.00%> (-1.86%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c876d...dce4175. Read the comment docs.

@pro-wh
Copy link
Contributor Author

pro-wh commented Apr 1, 2020

coverage is wrong. this line is hit

@pro-wh pro-wh merged commit a72bc87 into master Apr 1, 2020
@pro-wh pro-wh deleted the pro-wh/bugfix/gasimport branch April 1, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants