-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transfer workload include burns #2773
Conversation
ptrus
commented
Mar 19, 2020
- adds staking.Burn transactions to the transfer workload
- extracts repeated "estimateGas, fund caller, sign tx, submit tx" action into a helper function
af32751
to
54ecbab
Compare
Codecov Report
@@ Coverage Diff @@
## master #2773 +/- ##
==========================================
- Coverage 63.13% 62.71% -0.42%
==========================================
Files 387 387
Lines 36540 36526 -14
==========================================
- Hits 23070 22909 -161
- Misses 10554 10748 +194
+ Partials 2916 2869 -47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, is there some other kind of description somewhere we can use better to indicate that the "transfer" workload is 50-50 transfers and burns?
54ecbab
to
1e42253
Compare
1e42253
to
78fc3cb
Compare
added a comment to the name constant since i couldn't come up with a workload name better indicating it |