Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: test debonding entries from genesis #2747

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Feb 28, 2020

Here's an e2e test scenario that exercises debonding delegation records from the genesis document.

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #2747 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   62.74%   62.82%   +0.08%     
==========================================
  Files         384      384              
  Lines       36258    36258              
==========================================
+ Hits        22749    22779      +30     
+ Misses      10616    10585      -31     
- Partials     2893     2894       +1
Impacted Files Coverage Δ
go/worker/common/p2p/p2p.go 64.86% <0%> (-6.31%) ⬇️
go/storage/client/client.go 75.63% <0%> (-0.85%) ⬇️
go/runtime/client/client.go 66.28% <0%> (-0.77%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 48.76% <0%> (-0.55%) ⬇️
go/worker/registration/worker.go 66.34% <0%> (-0.49%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.03% <0%> (-0.31%) ⬇️
go/storage/database/database.go 76.31% <0%> (ø) ⬆️
go/worker/compute/merge/committee/node.go 75.87% <0%> (+0.49%) ⬆️
go/consensus/tendermint/tendermint.go 67.9% <0%> (+0.96%) ⬆️
go/worker/common/committee/group.go 80.98% <0%> (+1.31%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45718f...3d67f1d. Read the comment docs.

@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 3, 2020

Reviewers please review

Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm no code-owner but lgtm

@kostko
Copy link
Member

kostko commented Mar 4, 2020

Also make sure to revert #2672.

@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 4, 2020

@kostko after this PR I'll close #2727 and open a new PR for removing #2672 stuff

@pro-wh pro-wh force-pushed the pro-wh/feature/debondtest branch from edf7fa3 to c0fd699 Compare March 4, 2020 22:24
@pro-wh pro-wh requested a review from Yawning March 4, 2020 22:24
@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 5, 2020

#2753 for reverting that

@pro-wh pro-wh force-pushed the pro-wh/feature/debondtest branch from c0fd699 to 3d67f1d Compare March 5, 2020 18:42
@pro-wh pro-wh merged commit ecf2102 into master Mar 5, 2020
@pro-wh pro-wh deleted the pro-wh/feature/debondtest branch March 5, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants