Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Add Check go mod tidy step to ci-lint workflow #2717

Merged
merged 4 commits into from
Feb 25, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Feb 24, 2020

No description provided.

@tjanez tjanez added c:testing Category: testing golang c:deps Category: external dependencies labels Feb 24, 2020
@tjanez tjanez self-assigned this Feb 24, 2020
@tjanez tjanez force-pushed the tjanez/check-go-mod-tidy branch 2 times, most recently from 841f573 to 25ae479 Compare February 24, 2020 14:55
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2717 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
- Coverage    63.1%   62.99%   -0.11%     
==========================================
  Files         378      378              
  Lines       35532    35515      -17     
==========================================
- Hits        22421    22372      -49     
- Misses      10294    10313      +19     
- Partials     2817     2830      +13
Impacted Files Coverage Δ
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
go/consensus/tendermint/api/api.go 73.58% <0%> (-15.1%) ⬇️
go/runtime/committee/committee.go 74.02% <0%> (-10.39%) ⬇️
go/oasis-node/cmd/debug/storage/storage.go 45.08% <0%> (-3.47%) ⬇️
go/runtime/committee/nodes.go 80.64% <0%> (-2.16%) ⬇️
go/worker/common/committee/group.go 79.01% <0%> (-1.97%) ⬇️
go/worker/storage/committee/checkpointer.go 66.37% <0%> (-1.77%) ⬇️
go/storage/client/client.go 75.63% <0%> (-1.69%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.7% <0%> (-1.38%) ⬇️
go/common/grpc/grpc.go 77.59% <0%> (-1.25%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db3caef...9134697. Read the comment docs.

@tjanez tjanez force-pushed the tjanez/check-go-mod-tidy branch from 25ae479 to 5069888 Compare February 25, 2020 09:41
@tjanez tjanez force-pushed the tjanez/check-go-mod-tidy branch from 5069888 to 9134697 Compare February 25, 2020 10:13
@tjanez tjanez merged commit 2616c3c into master Feb 25, 2020
@tjanez tjanez deleted the tjanez/check-go-mod-tidy branch February 25, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies c:testing Category: testing golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants