Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/cmd/registry/runtime: fix provisioning a runtime without keymanager #2639

Merged
merged 1 commit into from
Feb 4, 2020
Merged

go/cmd/registry/runtime: fix provisioning a runtime without keymanager #2639

merged 1 commit into from
Feb 4, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Feb 4, 2020 •
edited
Loading

vipper.IsSet always returns true if key was bound to a PFlag. Also did check, and this is the only place where we're using viper.IsSet.

Apparently could also use:

flag := cmd.Flags().Lookup("flag-name")
if flag == nil || !flag.Changed {
    continue
}

but this seems clearer?

@ptrus
go/cmd/registry/runtime: fix provisioning a runtime without keymanager
d3e85a2 
vipper.IsSet returns true always if key was bound to a PFlag
@ptrus ptrus force-pushed the ptrus/fix/registry-cmd branch from 1c00583 to d3e85a2 Compare February 4, 2020 10:02
@ptrus ptrus self-assigned this Feb 4, 2020
@ptrus ptrus merged commit 6a09d57 into master Feb 4, 2020
@ptrus ptrus deleted the ptrus/fix/registry-cmd branch February 4, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yawning Yawning Yawning approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

Assignees

@ptrus ptrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptrus @Yawning