Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/staking/api: Check if thresholds for all kinds are defined in genesis #2633

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jan 31, 2020

Follow up to #2632.

@tjanez tjanez force-pushed the tjanez/staking-genesis-check-all-kinds branch from e4e975c to 01d29d0 Compare January 31, 2020 18:05
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2633 into master will decrease coverage by 0.15%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2633      +/-   ##
=========================================
- Coverage   63.25%   63.1%   -0.16%     
=========================================
  Files         360     360              
  Lines       34153   34156       +3     
=========================================
- Hits        21604   21554      -50     
- Misses       9895    9924      +29     
- Partials     2654    2678      +24
Impacted Files Coverage Δ
go/staking/api/sanity_check.go 52.94% <40%> (-0.6%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 51.68% <0%> (-6.75%) ⬇️
go/control/debug.go 67.74% <0%> (-6.46%) ⬇️
go/consensus/tendermint/apps/staking/query.go 68.57% <0%> (-5.72%) ⬇️
go/common/grpc/auth/auth.go 88.88% <0%> (-5.56%) ⬇️
go/oasis-node/cmd/stake/stake.go 71.05% <0%> (-4.39%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0%> (-4.35%) ⬇️
go/oasis-node/cmd/debug/storage/storage.go 45.08% <0%> (-3.47%) ⬇️
go/runtime/history/prune.go 74.19% <0%> (-3.23%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0%> (-2.71%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1489f8...3314d0c. Read the comment docs.

.changelog/2633.feature.md Outdated Show resolved Hide resolved
@tjanez tjanez force-pushed the tjanez/staking-genesis-check-all-kinds branch from 01d29d0 to ec01c47 Compare February 3, 2020 09:18
@tjanez tjanez self-assigned this Feb 3, 2020
Update stake-cli End-to-End test use a valid staking genesis document
and omit the invalid staking threshold kind warnings check from the info
subcommand.
@tjanez tjanez force-pushed the tjanez/staking-genesis-check-all-kinds branch from ec01c47 to 3314d0c Compare February 3, 2020 09:52
@tjanez tjanez merged commit d7d457f into master Feb 3, 2020
@tjanez tjanez deleted the tjanez/staking-genesis-check-all-kinds branch February 3, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants