You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to allow for go.mod to properly use tags when resolving oasis-core as a dependency it seems we must include go/ as a prefix in our tags. This is an excerpt from the the golang docs:
A new module version may be published by pushing a tag to the repository that contains the module source code. The tag is formed by concatenating two strings: a prefix and a version.
The version is the semantic import version for the release. It should be chosen by following the rules of semantic import versioning.
The prefix indicates where a module is defined within a repository. If the module is defined at the root of the repository, the prefix is empty, and the tag is just the version. However, in multi-module repositories, the prefix distinguishes versions for different modules. The prefix is the directory within the repository where the module is defined. If the repository follows the major subdirectory pattern described above, the prefix does not include the major version suffix.
For example, suppose we have a module example.com/repo/sub/v2, and we want to publish version v2.1.6. The repository root corresponds to example.com/repo, and the module is defined in sub/v2/go.mod within the repository. The prefix for this module is sub/. The full tag for this release should be sub/v2.1.6.
It doesn't: no matching versions for query "v20.6" :(
The hash that's currently there points to the v20.6 release, though, so it should be equivalent. Would be nice to have the tag working, though.
Also by reading the linked guide it seems that Go mandates semver, while we explicitly do not use semver and use calver instead. This may make some things annoying.
This has been worked around by using tags in the form of go/v0.20.9 (e.g., all our calver versions map under 0.*). We should update the tag-next-release target to also generate Go-specific tags.
In order to allow for
go.mod
to properly use tags when resolvingoasis-core
as a dependency it seems we must includego/
as a prefix in our tags. This is an excerpt from the the golang docs:See here for full details
@david-yan and I ran into this issue when trying to use
oasis-core
as a library in oasislabs/staking-transaction-clientI propose we make it so that our tags can be properly used by go modules by tagging our releases both as
vYY.x.y
andgo/vYY.x.y
.The text was updated successfully, but these errors were encountered: