Fix GoReleaser oasis-node build reproducibility issue #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running "make release" inside GitHub Actions would always try to create a real release as opposed to creating a local snapshot release. From now on, the OASIS_CORE_REAL_RELEASE environment varible must be set to "true" to instruct Make to create a real release.
GoReleaser doesn't support CGO and Oasis Core doesn't require it.
tjanez
requested review from
kostko,
peterjgilbert and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2590 +/- ##
==========================================
- Coverage 63.28% 63.16% -0.12%
==========================================
Files 357 357
Lines 33437 33437
==========================================
- Hits 21159 21122 -37
- Misses 9701 9712 +11
- Partials 2577 2603 +26
Continue to review full report at Codecov.
|
kostko
approved these changes
Jan 23, 2020
tjanez
force-pushed
the
tjanez/fix-goreleaser-reproducibility
branch
3 times, most recently
from
953adf8 to
afd4f86
Compare
As noted in 60641ce, this should be no longer necessary with Go 1.13.4+, but there appears to be a specific issue with GoReleaser's build handling.
tjanez
force-pushed
the
tjanez/fix-goreleaser-reproducibility
branch
from
afd4f86 to
b7b8ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571.
An example of how the new reproducibility workflow reports error: https://github.com/oasislabs/oasis-core/runs/405500021.