Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unfatalize" #2554

Merged
merged 3 commits into from
Feb 17, 2020
Merged

"unfatalize" #2554

merged 3 commits into from
Feb 17, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Jan 15, 2020

for record keeping: we put these bandaids on the seed node to skip over the unroutable nodes in the genesis document

@pro-wh pro-wh added the c:consensus/cometbft Category: CometBFT label Jan 15, 2020
@pro-wh pro-wh requested review from kostko and Yawning as code owners January 15, 2020 00:39
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #2554 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
+ Coverage   62.93%   62.99%   +0.05%     
==========================================
  Files         376      376              
  Lines       35319    35324       +5     
==========================================
+ Hits        22229    22252      +23     
+ Misses      10289    10278      -11     
+ Partials     2801     2794       -7
Impacted Files Coverage Δ
go/consensus/tendermint/seed.go 70% <0%> (-4.12%) ⬇️
go/genesis/api/api.go 53.33% <0%> (-20.01%) ⬇️
go/consensus/tendermint/abci/mux.go 66.58% <0%> (-4.99%) ⬇️
go/oasis-node/cmd/node/node.go 51.21% <0%> (-3.4%) ⬇️
go/runtime/tagindexer/tagindexer.go 70.65% <0%> (-2.18%) ⬇️
go/runtime/committee/nodes.go 80.64% <0%> (-2.16%) ⬇️
go/consensus/tendermint/abci/state.go 51.1% <0%> (-1.48%) ⬇️
go/runtime/transaction/transaction.go 77.1% <0%> (-1.21%) ⬇️
go/worker/compute/merge/committee/node.go 75.37% <0%> (-0.5%) ⬇️
go/worker/registration/worker.go 66.66% <0%> (-0.5%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f680dc2...59382ee. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/bugfix/unfatalize branch from 866aff8 to 1a8e27f Compare February 14, 2020 19:46
@pro-wh pro-wh requested a review from kostko February 14, 2020 19:46
.changelog/2554.bugfix.md Outdated Show resolved Hide resolved
go/consensus/tendermint/seed.go Outdated Show resolved Hide resolved
go/consensus/tendermint/seed.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/bugfix/unfatalize branch from c620ad5 to 59382ee Compare February 17, 2020 22:24
@pro-wh pro-wh merged commit ab684b4 into master Feb 17, 2020
@pro-wh pro-wh deleted the pro-wh/bugfix/unfatalize branch February 17, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:consensus/cometbft Category: CometBFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants