Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable consensus address checks at genesis #2552

Merged

Conversation

peterjgilbert
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #2552 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
+ Coverage    66.7%   66.82%   +0.11%     
==========================================
  Files         328      328              
  Lines       30262    30263       +1     
==========================================
+ Hits        20187    20222      +35     
+ Misses       7537     7500      -37     
- Partials     2538     2541       +3
Impacted Files Coverage Δ
go/registry/api/api.go 41.25% <100%> (+0.09%) ⬆️
go/common/cbor/codec.go 64.7% <0%> (-5.89%) ⬇️
go/storage/api/grpc.go 63.92% <0%> (-3.66%) ⬇️
go/storage/client/client.go 75% <0%> (-0.93%) ⬇️
go/worker/common/p2p/p2p.go 67.56% <0%> (-0.91%) ⬇️
go/consensus/tendermint/apps/roothash/roothash.go 68.8% <0%> (-0.65%) ⬇️
go/roothash/api/commitment/pool.go 68.43% <0%> (-0.59%) ⬇️
go/worker/common/host/sandboxed.go 71.31% <0%> (+0.39%) ⬆️
go/consensus/tendermint/tendermint.go 65.51% <0%> (+1%) ⬆️
go/worker/registration/worker.go 66.14% <0%> (+1.56%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f059460...4af892f. Read the comment docs.

@peterjgilbert peterjgilbert force-pushed the peterjgilbert/disable_consensus_addr_check_genesis branch from c0d66a6 to 4af892f Compare January 14, 2020 19:47
@peterjgilbert peterjgilbert merged commit 4363b0a into master Jan 14, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/disable_consensus_addr_check_genesis branch January 14, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants