Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per entity signature count tool #2500

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Dec 23, 2019

Implements a cli tool to query per entity signature counts.

Could potentially extract this into it's own repo.

@ptrus ptrus force-pushed the ptrus/feature/signature-count-tool branch from 985df1f to cff4b6e Compare December 23, 2019 12:19
@ptrus ptrus requested review from kostko and ravenac95 December 23, 2019 13:04
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #2500 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
+ Coverage   67.09%   67.23%   +0.14%     
==========================================
  Files         324      324              
  Lines       29893    29894       +1     
==========================================
+ Hits        20056    20100      +44     
+ Misses       7357     7320      -37     
+ Partials     2480     2474       -6
Impacted Files Coverage Δ
go/consensus/api/api.go 50% <ø> (ø) ⬆️
go/consensus/tendermint/api/api.go 73.58% <100%> (+0.5%) ⬆️
go/roothash/api/commitment/pool.go 69.02% <0%> (-1.48%) ⬇️
go/worker/storage/committee/node.go 77.65% <0%> (-0.28%) ⬇️
go/worker/merge/committee/node.go 75.12% <0%> (+0.48%) ⬆️
go/consensus/tendermint/tendermint.go 64.94% <0%> (+0.71%) ⬆️
go/runtime/transaction/transaction.go 78.04% <0%> (+1.21%) ⬆️
go/worker/compute/committee/node.go 67.85% <0%> (+1.26%) ⬆️
go/storage/client/client.go 71.37% <0%> (+1.44%) ⬆️
go/worker/common/committee/group.go 82.52% <0%> (+1.48%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d942d...b8cc045. Read the comment docs.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, did a quick review.

Maybe also add a readme into go/extra to describe what is in there.

.changelog/2500.feature.md Show resolved Hide resolved
go/extra/stats/.gitignore Outdated Show resolved Hide resolved
go/extra/stats/cmd/stats.go Outdated Show resolved Hide resolved
@kostko
Copy link
Member

kostko commented Dec 23, 2019

Could potentially extract this into it's own repo.

I think it is useful having this here for now.

@ptrus ptrus force-pushed the ptrus/feature/signature-count-tool branch 2 times, most recently from 54b143a to cff3a8f Compare December 23, 2019 14:10
@ptrus ptrus marked this pull request as ready for review December 23, 2019 14:17
@ravenac95
Copy link
Contributor

This looks good to me! My approval is meaningless here tho :).

@ptrus ptrus force-pushed the ptrus/feature/signature-count-tool branch from cff3a8f to b8cc045 Compare December 26, 2019 18:12
@ptrus ptrus merged commit 609047e into master Dec 26, 2019
@ptrus ptrus deleted the ptrus/feature/signature-count-tool branch December 26, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants