Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go staking: undisable transfers for some senders #2498

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Dec 21, 2019

ostensibly for faucet purposes while we run the rest of the network with transfers disabled, this lets us identify a whitelist of accounts from which we allow transfers when otherwise transfers are disabled.

cc #2481

@pro-wh pro-wh added c:consensus/cometbft Category: CometBFT c:staking Category: staking labels Dec 21, 2019
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #2498 into master will increase coverage by 0.1%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2498     +/-   ##
=========================================
+ Coverage   67.01%   67.11%   +0.1%     
=========================================
  Files         324      324             
  Lines       29880    29887      +7     
=========================================
+ Hits        20024    20060     +36     
+ Misses       7369     7343     -26     
+ Partials     2487     2484      -3
Impacted Files Coverage Δ
go/staking/api/api.go 50.89% <ø> (ø) ⬆️
.../consensus/tendermint/apps/staking/transactions.go 73.65% <44.44%> (-1.09%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/common/cbor/codec.go 64.7% <0%> (-5.89%) ⬇️
go/consensus/tendermint/tendermint.go 63.21% <0%> (-1.73%) ⬇️
go/worker/common/committee/group.go 81.04% <0%> (-1.49%) ⬇️
go/consensus/tendermint/apps/roothash/roothash.go 68.68% <0%> (-0.65%) ⬇️
go/worker/merge/committee/node.go 74.63% <0%> (-0.25%) ⬇️
go/storage/api/grpc.go 69.86% <0%> (+1.36%) ⬆️
go/worker/common/p2p/p2p.go 70.27% <0%> (+1.8%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329e023...65a3db6. Read the comment docs.

@pro-wh
Copy link
Contributor Author

pro-wh commented Dec 23, 2019

gonna add changelog and merge. tests coming in a separate PR

@pro-wh pro-wh force-pushed the pro-wh/feature/xferwl branch from ad66e10 to 65a3db6 Compare December 23, 2019 18:52
@pro-wh pro-wh merged commit c878579 into master Dec 23, 2019
@pro-wh pro-wh deleted the pro-wh/feature/xferwl branch December 23, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:consensus/cometbft Category: CometBFT c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants