Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key manager: Is transition between GetStatuses and subscription to status atomic? #2186

Closed
pro-wh opened this issue Sep 30, 2019 · 2 comments
Labels
c:key management Category: key management s:wontfix Status: this will not be worked on

Comments

@pro-wh
Copy link
Contributor

pro-wh commented Sep 30, 2019

in the tendermint keymanager backend, we have a subscription with an initialization callback that reads all current statuses before starting a susbscription to change events. are these two phases, the one that reads current statuses and the one that relays status change events, done atomically so that they can't miss an update or duplicate an update?

Details

encountered in go/keymanager/tendermint/tendermint.go

from internal key manager audit

Acceptance Criteria

  • either we know it's atomic already or we make it atomic. or we determine that it's not a concern
@pro-wh pro-wh added the c:key management Category: key management label Sep 30, 2019
@Yawning
Copy link
Contributor

Yawning commented Oct 1, 2019

It's not, but missing/duplicated updates are harmless enough that this isn't an issue.

If an update is missed, the only thing that happens is the client needs to wait for the next status to be able to use the key manager.

@pro-wh
Copy link
Contributor Author

pro-wh commented Oct 1, 2019

ok kool

@pro-wh pro-wh closed this as completed Oct 1, 2019
@Yawning Yawning added the s:wontfix Status: this will not be worked on label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:key management Category: key management s:wontfix Status: this will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants