Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Relax the update check to allow nodes to opt into more runtimes #2179

Closed
Yawning opened this issue Sep 26, 2019 · 0 comments · Fixed by #3083
Closed

go/registry: Relax the update check to allow nodes to opt into more runtimes #2179

Yawning opened this issue Sep 26, 2019 · 0 comments · Fixed by #3083
Assignees
Labels
c:registry Category: entity/node/runtime registry service golang p:2 Priority: desired feature s:good first issue Status: good for newcomers

Comments

@Yawning
Copy link
Contributor

Yawning commented Sep 26, 2019

Currently when a node update's it's registration, the list of runtimes needs to be identical (except for the attestation). This causes problems when a node that previously was not of a class that requires runtimes in the node descriptor (eg: a validator) wishes to opt-in to also being one that does (eg: a validator + compute worker).

The check here probably should also be relaxed to allow adding runtimes to the node descriptor on registration update.

@Yawning Yawning added s:good first issue Status: good for newcomers p:2 Priority: desired feature c:registry Category: entity/node/runtime registry service golang labels Sep 26, 2019
@abukosek abukosek self-assigned this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:registry Category: entity/node/runtime registry service golang p:2 Priority: desired feature s:good first issue Status: good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants