Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtimes should expose a CheckTx API #1555

Closed
kostko opened this issue Mar 29, 2019 · 1 comment · Fixed by #1675
Closed

Runtimes should expose a CheckTx API #1555

kostko opened this issue Mar 29, 2019 · 1 comment · Fixed by #1675
Assignees
Labels
c:runtime/compute Category: runtime compute worker c:runtime Category: runtime s:needs adr Needs a design document, discussion and decision (ADR)

Comments

@kostko
Copy link
Member

kostko commented Mar 29, 2019

Runtimes should expose a CheckTx API that allows the worker host to request runtime-specific light-weight transaction checks and immediately reject transactions if these checks fail (similar to Tendermint's CheckTx).

This can be used by the leader to reject transactions early before dispatching them to the compute committee. It may make sense to use a separate runtime instance to perform these checks to not block the main runtime from doing work while performing checks.

@kostko kostko added c:runtime/compute Category: runtime compute worker c:runtime Category: runtime labels Mar 29, 2019
@peterjgilbert
Copy link
Contributor

Runtimes should also expose an API to order transactions within a batch. This is needed if we want to be able to process multiple transactions from a given sender within a batch, as the Ethereum nonce must match exactly. Note this also requires batch ordering to be preserved across batch submission--not sure whether we guarantee this currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime/compute Category: runtime compute worker c:runtime Category: runtime s:needs adr Needs a design document, discussion and decision (ADR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants