Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: go build doesn't play nice with replace #1510

Closed
Yawning opened this issue Feb 26, 2019 · 1 comment
Closed

go: go build doesn't play nice with replace #1510

Yawning opened this issue Feb 26, 2019 · 1 comment
Labels
c:build Category: build environment golang

Comments

@Yawning
Copy link
Contributor

Yawning commented Feb 26, 2019

We have a huge replace block due to libp2p. This triggers golang/go#27859
which is annoying and adds time to the build process.

We can leave things as is for now and just deal with it as the problem will resolve itself in Go 1.12, or switch from the replace block to pointing at hashes in the require directive. From a maintainability standpoint I prefer the former, but if enough other people find the current behavior unbearable, we can change it.
@Yawning Yawning added c:build Category: build environment golang labels Feb 26, 2019
This was referenced Feb 26, 2019
Closed
Closed
@Yawning
Copy link
Contributor Author

Yawning commented Feb 28, 2019

Go 1.12 renders this moot, closing in favor of #1515.

arnhem :: ekiden/go/ekiden ‹yawning/feature/staking-backend*› % go1.12 build   
arnhem :: ekiden/go/ekiden ‹yawning/feature/staking-backend*› %

@Yawning Yawning closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:build Category: build environment golang
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yawning