Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/common/crypto/signature/signers/remote: Initial import #2686

Merged
merged 4 commits into from
Feb 26, 2020
Merged

go/common/crypto/signature/signers/remote: Initial import #2686

merged 4 commits into from
Feb 26, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Feb 17, 2020 •
edited
Loading

  • Implement the grpc client/server.
  • Write a simple remote server executable.
  • Wire in the configuration stuff to oasis-node.
  • Add test cases.
  • Add logging to the remote signer. (Deferred till I can think of something useful)

@Yawning Yawning added c:common Category: common libraries golang c:security Category: security sensitive labels Feb 17, 2020
@Yawning Yawning self-assigned this Feb 17, 2020
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from cf2f79d to bd30949 Compare February 17, 2020 13:24
@codecov
Copy link

codecov bot commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #2686 into master will decrease coverage by 0.29%.
The diff coverage is 24.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2686     +/-   ##
=========================================
- Coverage   63.11%   62.82%   -0.3%     
=========================================
  Files         378      381      +3     
  Lines       35538    35752    +214     
=========================================
+ Hits        22431    22462     +31     
- Misses      10285    10472    +187     
+ Partials     2822     2818      -4
Impacted Files Coverage Δ
go/oasis-node/cmd/common/flags/flags.go 94.73% <ø> (+9.02%) ⬆️
go/oasis-test-runner/oasis/oasis.go 0% <0%> (ø) ⬆️
go/oasis-test-runner/oasis/entity.go 0% <0%> (ø) ⬆️
go/common/grpc/auth/auth_tls.go 0% <0%> (ø)
go/oasis-test-runner/oasis/seed.go 0% <0%> (ø) ⬆️
...n/crypto/signature/signers/ledger/ledger_signer.go 0% <0%> (ø) ⬆️
go/oasis-test-runner/oasis/sentry.go 0% <0%> (ø) ⬆️
go/common/crypto/signature/signers/remote/grpc.go 0% <0%> (ø)
go/oasis-node/cmd/keymanager/keymanager.go 45.09% <0%> (-0.52%) ⬇️
go/worker/registration/worker.go 66.34% <0%> (-0.33%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71aa7f2...f83c880. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/remote-signer branch 16 times, most recently from 3afa5ec to d8aeef8 Compare February 21, 2020 14:33
@Yawning Yawning marked this pull request as ready for review February 21, 2020 14:33
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from d8aeef8 to 488224e Compare February 21, 2020 14:39
kostko
kostko reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be cool to have tests.

go/common/crypto/signature/signers/remote/grpc.go Outdated Show resolved Hide resolved
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from 488224e to df662e9 Compare February 24, 2020 10:24
kostko
kostko approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a simple test for the remote signer would still be nice.

go/common/crypto/signature/signers/remote/grpc.go Show resolved Hide resolved
go/common/crypto/signature/signer.go Show resolved Hide resolved
@Yawning Yawning mentioned this pull request Feb 24, 2020
Merged
16 tasks
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch 4 times, most recently from 4267c9f to 540fe9b Compare February 26, 2020 14:20
@Yawning Yawning requested a review from pro-wh as a code owner February 26, 2020 14:20
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from 540fe9b to 42e8414 Compare February 26, 2020 14:46
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from 42e8414 to 2a1215d Compare February 26, 2020 14:48
kostko
kostko approved these changes Feb 26, 2020
View reviewed changes
go/oasis-node/cmd/common/signer/signer.go
// NodeDirOrPwd returns the directory with the entity files, (and the signer
// keys for file-based signer).
//
// XXX: Why this doesn't use the perfectly good datadir is beyond me.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of don't want to mess with it.

.buildkite/scripts/test_e2e.sh Outdated Show resolved Hide resolved
@Yawning Yawning force-pushed the yawning/feature/remote-signer branch from 9507e70 to f83c880 Compare February 26, 2020 17:15
@Yawning Yawning merged commit 5037df1 into master Feb 26, 2020
@Yawning Yawning deleted the yawning/feature/remote-signer branch February 26, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees

@Yawning Yawning

Labels
c:common Category: common libraries c:security Category: security sensitive golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yawning @kostko