Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Update ed25519-dalek and associated dependencies #2678

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

peterjgilbert
Copy link
Contributor

@peterjgilbert peterjgilbert commented Feb 14, 2020

1.0.0-pre.3 needs rand 0.7

@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/ed25519-dalek branch from bf9fd09 to 14e5724 Compare February 14, 2020 22:46
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #2678 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
+ Coverage   63.09%   63.12%   +0.03%     
==========================================
  Files         376      376              
  Lines       35319    35319              
==========================================
+ Hits        22283    22294      +11     
  Misses      10230    10230              
+ Partials     2806     2795      -11     
Impacted Files Coverage Δ
go/worker/common/host/interface.go 38.46% <0.00%> (-15.39%) ⬇️
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 60.18% <0.00%> (-4.33%) ⬇️
go/worker/common/p2p/p2p.go 67.56% <0.00%> (-2.71%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0.00%> (-2.63%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.70% <0.00%> (-1.38%) ⬇️
go/common/grpc/grpc.go 77.59% <0.00%> (-1.25%) ⬇️
go/runtime/client/client.go 66.28% <0.00%> (-0.77%) ⬇️
go/roothash/tests/tester.go 95.54% <0.00%> (-0.64%) ⬇️
go/storage/client/client.go 78.15% <0.00%> (+0.84%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc5248...2862c9b. Read the comment docs.

@kostko
Copy link
Member

kostko commented Feb 16, 2020

What exactly is the problem with the rand crates? Is it a problem with SGX builds or in general?

@peterjgilbert
Copy link
Contributor Author

peterjgilbert commented Feb 16, 2020

Not specific to SGX builds. This is the error I get when compiling oasis-core-runtime outside of oasis-core:

...
   Compiling ed25519-dalek v1.0.0-pre.3
   Compiling oasis-core-runtime v0.3.0-alpha (https://github.com/oasislabs/oasis-core#a7d41660)
error[E0277]: the trait bound `rand_os::OsRng: rand_core::CryptoRng` is not satisfied
  --> /root/.cargo/git/checkouts/oasis-core-d1e566606c486e34/a7d4166/runtime/src/common/crypto/signature.rs:41:20
   |
41 |         PrivateKey(ed25519_dalek::Keypair::generate(&mut rng))
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::CryptoRng` is not implemented for `rand_os::OsRng`
   |
   = note: required by `ed25519_dalek::ed25519::Keypair::generate`

error[E0277]: the trait bound `rand_os::OsRng: rand_core::RngCore` is not satisfied
  --> /root/.cargo/git/checkouts/oasis-core-d1e566606c486e34/a7d4166/runtime/src/common/crypto/signature.rs:41:20
   |
41 |         PrivateKey(ed25519_dalek::Keypair::generate(&mut rng))
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::RngCore` is not implemented for `rand_os::OsRng`
   |
   = note: required by `ed25519_dalek::ed25519::Keypair::generate`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0277`.
error: Could not compile `oasis-core-runtime`.

@kostko
Copy link
Member

kostko commented Feb 17, 2020

If it is just that, it looks like something that would be simple to fix?

@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/ed25519-dalek branch from 14e5724 to 0b62984 Compare February 17, 2020 19:54
@peterjgilbert peterjgilbert changed the title runtime: pin ed25519-dalek dependency rust: Update ed25519-dalek and associated dependencies Feb 17, 2020
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/ed25519-dalek branch from 8def1cc to 2862c9b Compare February 17, 2020 21:36
@peterjgilbert peterjgilbert merged commit f680dc2 into master Feb 17, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/bugfix/ed25519-dalek branch February 17, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants