Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry/api/sanitycheck: move genesis stateroot check into registration #2643

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Feb 5, 2020

rt.Genesis.StateRoot.IsEmpty check should only be done when registering (otherwise supplementarysanity checks are failing)

@ptrus ptrus force-pushed the ptrus/fix/sanity-check-registry branch from 008dfde to 08401e5 Compare February 5, 2020 10:33
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #2643 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
- Coverage   63.06%   62.99%   -0.08%     
==========================================
  Files         364      364              
  Lines       34329    34330       +1     
==========================================
- Hits        21651    21626      -25     
- Misses      10027    10061      +34     
+ Partials     2651     2643       -8
Impacted Files Coverage Δ
go/registry/api/api.go 36.82% <ø> (+0.11%) ⬆️
...consensus/tendermint/apps/registry/transactions.go 46.49% <0%> (-0.4%) ⬇️
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0%> (-14.82%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/worker/compute/executor/committee/node.go 62.84% <0%> (-3.17%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-2.99%) ⬇️
go/worker/storage/service_external.go 51.68% <0%> (-2.25%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.02% <0%> (-2.22%) ⬇️
go/worker/common/host/sandboxed.go 75.35% <0%> (-0.62%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b5e03...08401e5. Read the comment docs.

@ptrus ptrus self-assigned this Feb 5, 2020
@ptrus ptrus merged commit ce180b8 into master Feb 5, 2020
@ptrus ptrus deleted the ptrus/fix/sanity-check-registry branch February 5, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants