Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mechanism #2607

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Upgrade mechanism #2607

merged 3 commits into from
Feb 14, 2020

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Jan 28, 2020 •
edited
Loading

Fixes #2547
Closes #2465
Closes #2466
Closes #2467

@jberci jberci force-pushed the jberci/feature/upgrade branch from b68b298 to 5720e6b Compare January 29, 2020 16:25
kostko
kostko reviewed Jan 29, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a quick look, will continue tomorrow.

go/consensus/tendermint/abci/mux.go Outdated Show resolved Hide resolved
go/consensus/tendermint/abci/mux.go Outdated Show resolved Hide resolved
kostko
kostko reviewed Jan 30, 2020
View reviewed changes
go/control/api/api.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Outdated Show resolved Hide resolved
go/upgrade/migrations/migrations.go Outdated Show resolved Hide resolved
go/upgrade/upgrade.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/upgrade branch from 5720e6b to f2352eb Compare January 31, 2020 16:37
kostko
kostko reviewed Jan 31, 2020
View reviewed changes
go/consensus/tendermint/abci/mux.go Outdated Show resolved Hide resolved
go/go.mod Outdated Show resolved Hide resolved
go/control/control.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/byzantine/tendermint.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Show resolved Hide resolved
go/upgrade/migrations/migrations.go Show resolved Hide resolved
go/consensus/tendermint/abci/state.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/upgrade branch from f2352eb to 8bcf359 Compare February 3, 2020 13:14
@jberci jberci force-pushed the jberci/feature/upgrade branch 3 times, most recently from 2e5dbce to fe47ce5 Compare February 10, 2020 15:05
@jberci jberci marked this pull request as ready for review February 10, 2020 15:07
@jberci jberci force-pushed the jberci/feature/upgrade branch from fe47ce5 to f9760d0 Compare February 11, 2020 13:47
kostko
kostko reviewed Feb 11, 2020
View reviewed changes
.changelog/2607.feature.md Outdated Show resolved Hide resolved
go/consensus/tendermint/abci/mux.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/node/node.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Show resolved Hide resolved
go/upgrade/migrations/dummy.go Show resolved Hide resolved
go/upgrade/upgrade.go Show resolved Hide resolved
go/upgrade/upgrade.go Show resolved Hide resolved
go/upgrade/upgrade.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/upgrade branch from f9760d0 to 7589b67 Compare February 11, 2020 17:53
kostko
kostko reviewed Feb 12, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, some minor nits and tests seem to be failing.

go/oasis-test-runner/scenario/e2e/upgrade.go Outdated Show resolved Hide resolved
go/upgrade/api/api.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/upgrade branch 4 times, most recently from a7dee38 to 5249783 Compare February 12, 2020 16:07
kostko
kostko reviewed Feb 12, 2020
View reviewed changes
go/upgrade/upgrade.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/upgrade branch 2 times, most recently from 3d7e269 to 07e7e69 Compare February 13, 2020 12:54
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #2607 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
+ Coverage   63.05%   63.11%   +0.05%     
==========================================
  Files         365      370       +5     
  Lines       34577    34905     +328     
==========================================
+ Hits        21804    22031     +227     
- Misses      10058    10129      +71     
- Partials     2715     2745      +30
Impacted Files Coverage Δ
go/consensus/api/grpc.go 57.02% <0.00%> (-6.62%) ⬇️
go/runtime/committee/nodes.go 80.64% <0.00%> (-4.31%) ⬇️
go/storage/metrics.go 73.21% <0.00%> (-2.68%) ⬇️
go/storage/mkvs/urkel/lookup.go 72.72% <0.00%> (-2.28%) ⬇️
go/consensus/tendermint/tendermint.go 66.20% <0.00%> (-1.35%) ⬇️
go/roothash/tests/tester.go 95.54% <0.00%> (-0.64%) ⬇️
go/worker/common/host/sandboxed.go 75.35% <0.00%> (-0.62%) ⬇️
go/worker/compute/merge/committee/node.go 75.75% <0.00%> (-0.50%) ⬇️
go/upgrade/upgrade.go 68.91% <0.00%> (ø)
go/upgrade/migrations/dummy.go 92.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74744ad...f0da65f. Read the comment docs.

@jberci jberci force-pushed the jberci/feature/upgrade branch 2 times, most recently from 8b62e35 to e42cb71 Compare February 13, 2020 14:42
@jberci jberci force-pushed the jberci/feature/upgrade branch from e42cb71 to f0da65f Compare February 14, 2020 12:08
@jberci jberci merged commit 5aa8cea into master Feb 14, 2020
@jberci jberci deleted the jberci/feature/upgrade branch February 14, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jberci @kostko