Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txsource #2478

Merged
merged 12 commits into from
Dec 30, 2019
Merged

Add txsource #2478

merged 12 commits into from
Dec 30, 2019

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Dec 17, 2019

The so-called "txsource" utility introduced in this PR is a starting point for something like a client that sends transactions for a long period of time, for the purpose of creating long-running tests.

With this change is a preliminary sample "workload"--a DRBG-backed schedule of transactions--which transfers staking tokens around among a set of test accounts.

cc #2277

@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch 5 times, most recently from 4956f16 to 5c1ef37 Compare December 20, 2019 19:58
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #2478 into master will decrease coverage by 0.1%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
- Coverage   66.92%   66.81%   -0.11%     
==========================================
  Files         325      328       +3     
  Lines       29937    30077     +140     
==========================================
+ Hits        20034    20096      +62     
- Misses       7396     7500     +104     
+ Partials     2507     2481      -26
Impacted Files Coverage Δ
.../cmd/debug/txsource/workload/runtimeplaceholder.go 0% <0%> (ø)
...oasis-node/cmd/debug/txsource/workload/transfer.go 0% <0%> (ø)
go/oasis-node/cmd/debug/debug.go 100% <100%> (ø) ⬆️
go/oasis-node/cmd/debug/txsource/txsource.go 22.41% <22.41%> (ø)
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/consensus/tendermint/tendermint.go 63.79% <0%> (-0.87%) ⬇️
go/roothash/api/commitment/pool.go 70.5% <0%> (-0.59%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95370a2...bc02252. Read the comment docs.

@pro-wh pro-wh marked this pull request as ready for review December 20, 2019 20:58
@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch 3 times, most recently from 58c2f86 to 48ec72e Compare December 20, 2019 23:55
@pro-wh
Copy link
Contributor Author

pro-wh commented Dec 21, 2019

ok there's a new daily pipeline https://buildkite.com/oasislabs/oasis-core-long-term-runs/builds/4#_ for this, but it's very boring because the client logs go to a file

current issues: builds would always show up as timed out. probably ought to have a graceful run-for-how-long setting

@pro-wh
Copy link
Contributor Author

pro-wh commented Dec 23, 2019

https://buildkite.com/oasislabs/oasis-core-long-term-runs/builds/4#_ hm the test run died after an hour with "agent lost." even though it was on a stable agent

@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch from 48ec72e to 26b3fc3 Compare December 23, 2019 22:29
go/oasis-node/cmd/debug/txsource/workload/workload.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/workload.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/txsource.go Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/txsource.go Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/txsource.go Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/txsource.go Outdated Show resolved Hide resolved
.changelog/2478.feature.md Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch 3 times, most recently from 22ed5d0 to 95dcdc1 Compare December 26, 2019 23:12
@pro-wh
Copy link
Contributor Author

pro-wh commented Dec 26, 2019

added time limit for finite-duration runs on CI |:

@pro-wh pro-wh requested a review from kostko December 27, 2019 01:08
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits otherwise this is good to merge. Don't forget to squash commits.

go/oasis-node/cmd/debug/txsource/workload/transfer.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/junk.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch from 433676a to c75d178 Compare December 30, 2019 19:09
@pro-wh
Copy link
Contributor Author

pro-wh commented Dec 30, 2019

alright gonna squash some and merge

pro-wh and others added 7 commits December 30, 2019 11:16
Squashed from
tests: add explanation to txsource fixture data
go txsource: log workload name in a few more places
go txsource: add some doc blocks to exported things
Co-Authored-By: Jernej Kos <[email protected]>
Squashed from
go txsource: switch to HeightLatest
go txsource: add doc to Workload
go txsource: only one thing in junk.go anyway
go txsource: separate workloads' log tags
@pro-wh pro-wh force-pushed the pro-wh/feature/txsource branch from c75d178 to bc02252 Compare December 30, 2019 19:18
@pro-wh pro-wh merged commit 2a0cbfe into master Dec 30, 2019
@pro-wh pro-wh deleted the pro-wh/feature/txsource branch December 30, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants