You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of manually and statically specifying sentry nodes as validator's persistent peers, support automatically configuring them upon querying sentry nodes for their consensus addresses and automatically restarting the Tenderming service (if necessary).
Instead of manually disabling Tendermint's Peer exchange reactor when using sentry nodes, do that automatically (if sentry nodes are configured).
The text was updated successfully, but these errors were encountered:
Instead of manually and statically specifying sentry nodes as validator's persistent peers, support automatically configuring them upon querying sentry nodes for their consensus addresses and automatically restarting the Tenderming service (if necessary).
looking at the tendermint code, this would require restarting the tedermint service. That together with the fact that validators don't technically need to specify sentries as persistent peers probably makes implementing this not really worth considering the effort vs benefits.
Instead of manually disabling Tendermint's Peer exchange reactor when using sentry nodes, do that automatically (if sentry nodes are configured).
Since disable_pex flag is useful by itself (e.g. someone might want to connect to known trusted nodes via persistent peers and disable pex) i think having to manually disable pex reactor is fine.
However i did try to address some other "simplifications" in #2560
Since disable_pex flag is useful by itself (e.g. someone might want to connect to known trusted nodes via persistent peers and disable pex) i think having to manually disable pex reactor is fine.
Yeah having an option to disable PEX manually seems reasonable, but is there ever a need for having PEX enabled on the upstream node when using sentry nodes? If not, you can do both -- keep the manual "disable PEX" option and also automatically disable PEX on the upstream node when using sentry nodes.
After initial Sentry node support is implemented, simplify the sentry node setup:
The text was updated successfully, but these errors were encountered: