Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text related to what properties are appropriate for versioning is ambiguous #234

Closed
rpiazza opened this issue Sep 18, 2020 · 4 comments
Closed

Comments

@rpiazza
Copy link
Contributor

rpiazza commented Sep 18, 2020

It should be clear what versioning related common property combinations are appropriate. For instance, having revoked without created and/or modified makes no sense.

See discussion on oasis-open/cti-python-stix2#458

@jordan2175
Copy link

We should discuss as this would be new text. Depending on the text, this could be a clarification or a material change.

@jordan2175
Copy link

In the 2nd to last paragraph of 3.6 the following text should be changed:

Producers who do this SHOULD use the property names created_by_ref, created, modified, and revoked.

with

Producers who do this MUST use all of the following property names: created_by_ref, created, modified, and revoked.

There can be an issue if someone was to accidentally just use one of the properties and not all of them.

@rpiazza
Copy link
Contributor Author

rpiazza commented Apr 20, 2021

Also, the text current says:

In STIX 2.1, SCOs do not explicitly have those three versioning properties. Therefore, a SCO cannot be versioned unless extensions are used as discussed in section 7.3. Producers who do this SHOULD use the property names created_by_ref, created, modified, and revoked.

Are we saying that you can do this using the deprecated custom properties?

@jordan2175
Copy link

jordan2175 commented Apr 27, 2021

We reworded the first paragraph to include the contents from the 2nd to last paragraph. The new first paragraph reads as:

Versioning is the mechanism that object creators use to update and revoke the STIX Objects that they create. This section describes the versioning process and normative rules for performing versioning and revocation. STIX Objects that are versioned MUST use the property names created_by_ref, created, modified, and revoked. SCOs are not versioned and thus do not have the four versioning properties. See the properties table in section 3.2 for full definitions and normative usage of those properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants