Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mixing single objects and lists in bundle constructor #430

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Allow mixing single objects and lists in bundle constructor #430

merged 1 commit into from
Jul 22, 2020

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Jul 20, 2020

Related: #429.

@clenk
Allow mixing single objects and lists in bundles
8063891 
...in bundle constructor

Related: #429.
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #430 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         130      130           
  Lines       14886    14892    +6     
=======================================
+ Hits        14644    14650    +6     
  Misses        242      242
Impacted Files Coverage Δ
stix2/v20/bundle.py 100.00% <100.00%> (ø)
stix2/v21/bundle.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c497038...8063891. Read the comment docs.

emmanvg
emmanvg approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok.

@emmanvg emmanvg self-requested a review July 22, 2020 15:23
emmanvg
emmanvg approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok.

@emmanvg emmanvg merged commit bb82bee into master Jul 22, 2020
@emmanvg emmanvg deleted the bundle-objs-and-lists branch July 22, 2020 17:00
@emmanvg emmanvg added this to the 2.0.3 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanvg emmanvg emmanvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clenk @codecov-commenter @emmanvg