Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change software SCO: os_execution_envs -> operating_system_refs #369

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Change software SCO: os_execution_envs -> operating_system_refs #369

merged 1 commit into from
Mar 12, 2020

Conversation

chisholm
Copy link
Contributor

@chisholm chisholm commented Mar 6, 2020

Fixes #367

@codecov-io
Copy link

codecov-io commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #369 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   98.18%   98.18%   +<.01%     
==========================================
  Files         124      124              
  Lines       14230    14234       +4     
==========================================
+ Hits        13972    13976       +4     
  Misses        258      258
Impacted Files Coverage Δ
stix2/v21/sdo.py 94.53% <ø> (ø) ⬆️
stix2/test/v21/test_malware.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3803e4b...6494470. Read the comment docs.

@chisholm
Change the os_execution_envs property of software SCOs to
792cc57 
operating_system_refs, and add a test for it.
clenk
clenk approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit e782d09 into oasis-open:master Mar 12, 2020
@emmanvg emmanvg added this to the 1.4.0 milestone Mar 12, 2020
@chisholm chisholm deleted the malware_os_refs branch April 3, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Malware os_execution_envs changes
4 participants
@chisholm @codecov-io @clenk @emmanvg