-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swid property to the software SCO #358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 98.15% 98.18% +0.03%
==========================================
Files 124 124
Lines 14176 14229 +53
==========================================
+ Hits 13914 13971 +57
+ Misses 262 258 -4
Continue to review full report at Codecov.
|
I think the format of swid tags is more like |
@clenk, @chisholm - looked at examples in https://nvlpubs.nist.gov/nistpubs/ir/2016/NIST.IR.8060.pdf Here is a good one: Maybe change the cpe one to correspond to this? |
I was looking for info about tagIds too when I was developing this. I couldn't get a free spec anywhere, so I was just trying to uncover whatever bits of information I could. I don't remember where I saw it, but I remember reading that they aren't required to be any particular thing. There may be some "should" rules around them though. So a UUID seemed good enough, and not technically wrong. But I'll change the test. |
more plausible.
Yes - I agree - its not defined very well. It took the text for the STIX spec directly from the document I referred to above. |
Thanks @chisholm! |
Fixes #349