Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom observable machinery for STIX 2.1 #299

Closed
chisholm opened this issue Oct 9, 2019 · 1 comment
Closed

Fix custom observable machinery for STIX 2.1 #299

chisholm opened this issue Oct 9, 2019 · 1 comment

Comments

@chisholm
Copy link
Contributor

chisholm commented Oct 9, 2019

Although there are different CustomObservable decorators for STIX 2.0 and 2.1, they both use the same _custom_observable_builder() function to create the custom class. That function does things which don't make sense for STIX 2.1. The system needs to be changed/updated to make sense with both STIX versions.

For example, one of the things that function does is to check whether properties named "*_ref(s)" use an instance of ObjectReferenceProperty. That class was specifically written to interact with validation of old-style SCOs, i.e. those embedded in the objects property of the 2.0 observed-data SDO. The design of SCOs has had significant changes in STIX 2.1, and the check doesn't make sense with that version of custom observable.

@khdesai khdesai mentioned this issue Nov 6, 2019
@clenk
Copy link
Contributor

clenk commented Dec 10, 2019

This was fixed by #297.

@clenk clenk closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants