Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split PBRMaterial and PBRSpecular Shader #481

Closed
GuoLei1990 opened this issue Sep 6, 2021 · 0 comments · Fixed by #514
Closed

Split PBRMaterial and PBRSpecular Shader #481

GuoLei1990 opened this issue Sep 6, 2021 · 0 comments · Fixed by #514
Assignees
@zhuxudong
Labels
enhancement New feature or request high priority High priority issue Rendering Rendering related functions
Milestone
0.6

Comments

@GuoLei1990
Copy link
Member

GuoLei1990 commented Sep 6, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

PR reviewers: @GuoLei1990 , @gz65555 , @yangfengzzz
@GuoLei1990 GuoLei1990 added enhancement New feature or request Rendering Rendering related functions labels Sep 6, 2021
@GuoLei1990 GuoLei1990 added this to the 0.6 milestone Sep 6, 2021
@GuoLei1990 GuoLei1990 added high priority High priority issue Rendering Rendering related functions and removed Rendering Rendering related functions high priority High priority issue labels Sep 6, 2021
@zhuxudong zhuxudong mentioned this issue Sep 16, 2021
Merged
3 tasks
@GuoLei1990 GuoLei1990 linked a pull request Sep 17, 2021 that will close this issue
Refactor: split pbr shader #514
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuxudong zhuxudong

Labels
enhancement New feature or request high priority High priority issue Rendering Rendering related functions
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Refactor: split pbr shader zhuxudong/engine
2 participants
@GuoLei1990 @zhuxudong