This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-196] clean up native sql options #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
commented
Mar 30, 2021
|
|
||
| // for all operators | ||
| val enableCpu = getCpu() | ||
|
|
There was a problem hiding this comment.
missing option for project and hashagg
|
|
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_cleanup_option
branch
from
e926f6e to
360b0e7
Compare
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
|
|
|
@weiting-chen we might should provide a sample configuration as well |
The code looks good for me, just confirm one thing: For sample configuration, we can add it in the document for OAP v1.1 release. Check if this PR can backport to v1.1 as well. |
weiting-chen
approved these changes
Apr 13, 2021
Signed-off-by: Yuan Zhou <[email protected]>
|
|
zhouyuan
added a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Apr 15, 2021
* clean up native sql options Signed-off-by: Yuan Zhou <[email protected]> * adding more options Signed-off-by: Yuan Zhou <[email protected]> * adding more options Signed-off-by: Yuan Zhou <[email protected]> * adding warning log for running on non-intel cpu Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
added a commit
that referenced
this pull request
Apr 19, 2021
* [NSE-229] Fix the deprecated code warning in shuffle_split_test (#230) * fix the deprecated code warning in shuffle_split_test * fix the code style * format update * [NSE-239] Adopt ARROW-7011 (#240) * [NSE-224] update third party code (#242) * update third party code Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * [NSE-176]Arrow install order issue (#231) * Add Arrow install script * [NSE-176]Add Arrow install Script in Arrow Data Source * remove popd parameter for ubuntu * Change variables to BFS * Update Arrow Header and Find Arrow function * Fix one issue with reading wrong Arrow Path * Update ARROW_CSV=ON * Update build_arrow=OFF in Scala UT * Install parent pom file in Scala UT * [NSE-196] clean up native sql options (#215) * clean up native sql options Signed-off-by: Yuan Zhou <[email protected]> * adding more options Signed-off-by: Yuan Zhou <[email protected]> * adding more options Signed-off-by: Yuan Zhou <[email protected]> * adding warning log for running on non-intel cpu Signed-off-by: Yuan Zhou <[email protected]> * [NSE-206]doc update on feature support status (#253) * update operators support status Signed-off-by: Yuan Zhou <[email protected]> * update docs on operators supporting status Signed-off-by: Yuan Zhou <[email protected]> * fix Signed-off-by: Yuan Zhou <[email protected]> * [NSE-241] fix hashagg result length (#249) * fix hashagg result length Signed-off-by: Yuan Zhou <[email protected]> * optimize on getting batch size Signed-off-by: Yuan Zhou <[email protected]> * using fixed sized output len for hashagg Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * [NSE-248] fix arrow dependency order (#259) * Only read .so.300.0.0 * Fix arroow dataset dependency issue * Add ARROW_S3=ON, Add symlink copy in CMakeList. Co-authored-by: JiaKe <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: Wei-Ting Chen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fixes: #196
Signed-off-by: Yuan Zhou [email protected]
How was this patch tested?
locally verified