This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Fix BHJ loss if key = 0 #293

Closed

zhouyuan opened this issue Apr 29, 2021 · 0 comments · Fixed by #294

Labels

bug

Collaborator

zhouyuan commented Apr 29, 2021

the cache_key will ignore '0' and return -1
https://github.com/oap-project/native-sql-engine/blob/master/native-sql-engine/cpp/src/codegen/common/hash_relation.h#L447
https://github.com/oap-project/native-sql-engine/blob/master/native-sql-engine/cpp/src/codegen/common/hash_relation.h#L332

zhouyuan added the bug label

zhouyuan mentioned this issue

[NSE-293] fix unsafemap with key = '0' #294

Merged

zhouyuan closed this as completed in #294

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.