Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Optimize cast WSCG performance #1144

Closed
jackylee-ch opened this issue Oct 25, 2022 · 1 comment
Closed

Optimize cast WSCG performance #1144

jackylee-ch opened this issue Oct 25, 2022 · 1 comment
Labels
enhancement New feature or request performance

Comments

@jackylee-ch
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently we use stod or stoi in cast WSCG, and it has a bad behavior while using cast.

Describe the solution you'd like
We can use the implement in arrow for the cast WSCG.

Describe alternatives you've considered
Or we can use from_chars that supported in c++17.
@jackylee-ch jackylee-ch added the enhancement New feature or request label Oct 25, 2022
@github-actions github-actions bot mentioned this issue Oct 25, 2022
Merged
@haojinIntel
Copy link
Collaborator

Closed by #1145. Thanks for your work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackylee-ch @haojinIntel