Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Limitations in columnar sort #1070

Open
kepler42 opened this issue Aug 16, 2022 · 1 comment
Open

Limitations in columnar sort #1070

kepler42 opened this issue Aug 16, 2022 · 1 comment

Comments

@kepler42
Copy link

kepler42 commented Aug 16, 2022

The limitation mentioned in docs mention not supporting spill. But there are multiple test cases for sort supporting spill to the disk using external sorter and the sort and spill method within sort kernel.

The limitations talked about are they due to these variables?
uint32_t id = 0;
uint32_t array_id = 0;

@zhouyuan
Copy link
Collaborator

zhouyuan commented Sep 7, 2022

Hi @kepler42

Yes, the limitation is due to some small data structure used(unit16_t, to reduce the memory footprint) in 1.4 and previous releases. We are working on to fix these in 1.5, here's the 1st patch:
#1038
The code path on Spilling support will also need to be cleaned up, WIP

-yuan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants