Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embark-target-injection-hooks with embark-become #741

Open
spepo opened this issue Nov 11, 2024 · 0 comments
Open

embark-target-injection-hooks with embark-become #741

spepo opened this issue Nov 11, 2024 · 0 comments

Comments

@spepo
Copy link

spepo commented Nov 11, 2024

Hi,

First of all, thank you so much for this wonderful package. I just started using it, so my apologies if I am asking something that was discussed before.

I'm trying to use embark-become such that the minibuffer content is modified before passing it through. It could go to a different command or even the same command (in my case consult-grep). From the documentation I assumed that configuring embark-target-injection-hooks would work, but I found that they are not called for some minibuffer-only actions, including embark-become. I see that embark--become-command always inserts the content as retrieved by embark-become. It doesn't treat the minibuffer input as a 'target' that is getting injected.

Would it make sense to generalize embark-become and embark-target-injection-hooks so the two can work together? I'd expect there to be other use cases that require altering the minibuffer content during embark-become.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant