Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking remaining but notable issues in v1alpha2 release #353

Closed
resouer opened this issue May 2, 2020 · 2 comments
Closed

Tracking remaining but notable issues in v1alpha2 release #353

resouer opened this issue May 2, 2020 · 2 comments
Milestone

Comments

@resouer
Copy link
Member

resouer commented May 2, 2020

Though still under pre-release, OAM v1alpha2 has been adopted rapidly among significant community platform builders recently. Based on the feedbacks, I'd suggest we consider the remaining issues as a whole picture of a production level application model.

The principle is we only want to have minimal impact on v1alpha2 release, thus I highly recommend we follow "promotion based API change" approach which has been practiced in Kubernetes community for years, i.e. use outbound objects and unstructured annotations instead of direct API change for alpha stage features and then promote it to API fields in beta.

So I'd assume the first version of above change swill happen on implementation side by annotations, and then we promote the API change to OAM spec according to users' feedback in further releases.

@resouer
Copy link
Member Author

resouer commented May 4, 2020

Clarify: #334 is better to be introduced to OAM spec instead of implementation. The reason I listed here is it can be used to solve #326 (component dependency) if we decide to move #334 forward in impl side firstly. Otherwise, we can defer it and focus on #326 .

I've updated the issue to reflect this idea. /cc @artursouza

@resouer
Copy link
Member Author

resouer commented May 28, 2020

[Update] According feedback from community as well as maintainers. It seems we are more inclined to change the OAM spec instead of annotations or temporary objects to ship above features in oam-kubernetes-runtime. See: crossplane/oam-kubernetes-runtime#24 (review) crossplane/oam-kubernetes-runtime#29 (comment).

It's very reasonable. So we will create new fields or API objects in implementation side directly and reflect them in the spec doc as EXPERIMENTAL . Though in order to keep the spec versioned and maintainable, we will add a mechanism to enable API spec promotion. Will raise this discussion as follow up issue.

@resouer resouer added this to the v0.2.2 milestone Oct 5, 2020
@resouer resouer closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant