Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aria label for buttons and reduce complexity #464

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: aria label for buttons and reduce complexity #464

merged 1 commit into from
Jan 7, 2025

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Jan 7, 2025

Description

  • The ButtonCore component was emitting arial-label="[object Object]"
  • It was also failing a code complexity check
  • This resolves the aria issue by only providing an aria-label if it is an icon, otherwise the button text would be deduced by the browser
  • Refactors the ButtonCore component to break it into sub-components

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:23am

@stefl stefl changed the title fix: Aria label for buttons, reduce complexity fix: aria label for buttons, reduce complexity Jan 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Playwright test results

passed  15 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  17 tests across 16 suites
duration  2 minutes, 23 seconds
commit  6ccad06

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI
No persona › tests/chat-performance.test.ts › Component renders during lesson chat › There are no unnecessary rerenders across left and right side of chat

@stefl stefl requested a review from a team January 7, 2025 13:40
codeincontext
codeincontext approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking. This makes sense to me

@stefl stefl changed the title fix: aria label for buttons, reduce complexity fix: aria label for buttons and reduce complexity Jan 7, 2025
@stefl stefl merged commit 79972b4 into main Jan 7, 2025
22 of 23 checks passed
@stefl stefl deleted the fix/button_label branch January 7, 2025 15:02
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext