Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test coverage #406

Merged
merged 21 commits into from
Dec 3, 2024
Merged

feat: test coverage #406

merged 21 commits into from
Dec 3, 2024

Conversation

JBR90
Copy link
Contributor

@JBR90 JBR90 commented Nov 28, 2024 •
edited
Loading

Description

  • Adds an additional Sonar step to upload test coverage when merging to production branch

How to test

We should see test coverage in tests when this is merged to production

Checklist

  • Manually tested across browsers / devices
  • Considered impact on accessibility
  • Does this PR update a package with a breaking change

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 0:04am

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 8 seconds
commit  6b1c3f1

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@JBR90 JBR90 requested a review from a team November 29, 2024 16:35
@JBR90 JBR90 marked this pull request as ready for review November 29, 2024 16:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
66.7% Duplication on New Code

See analysis details on SonarQube Cloud

@JBR90 JBR90 merged commit 00767a0 into main Dec 3, 2024
17 checks passed
@JBR90 JBR90 deleted the feat-test-coverage branch December 3, 2024 12:36
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefl stefl stefl approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBR90 @oak-machine-user @stefl